Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product switcher header to fiori3 concept #669

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Jul 22, 2019
@JohannesDoberer JohannesDoberer added this to the Sprint_2 milestone Jul 22, 2019
@marynaKhromova marynaKhromova self-assigned this Jul 22, 2019
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've refactored a bit styles and html. Let me know if it looks fine for you as well :)

I left only one small question. Check it below.

Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm)

@jesusreal jesusreal self-assigned this Jul 25, 2019
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments.

core/src/navigation/ProductSwitcher.html Show resolved Hide resolved
core/src/navigation/ProductSwitcher.html Outdated Show resolved Hide resolved
core/src/navigation/ProductSwitcher.html Show resolved Hide resolved
maxmarkus and others added 3 commits July 26, 2019 12:37
@JohannesDoberer JohannesDoberer merged commit 4f79902 into SAP:master Jul 29, 2019
@JohannesDoberer JohannesDoberer deleted the change-product-switcher-header-to-fiori3-concept- branch July 29, 2019 15:36
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants